Castle Paradox

Ysoft_Entertainment · Posted: Mon Apr 26, 2004 7:02 pm Post subject: Here is a script from DW1

hey check out this script, and tell me if it can be made shorter
basically what it does, lets you buy six keys(inventory( Cool

)
if you have more then six keys, it won't let you buy more
also if you don't have money it wont let you buy more keys(naturally, nothing is free)
now the script works find, its just I was wandering if it can be made simpler.

TMC · Posted: Tue Apr 27, 2004 2:22 am Post subject:

Almost everything can be simplified. And THAT rambling monstrosity can certainly be simplified.

You say the same thing over and over. I found FOUR instances of

if (paymoney(gold)) then (
getmoney(gold)
)

It shouldn't really not work fine.
while ((t) and (checktag(20)==on) ) do(
should not compile, but if it does, it's easy to see why it still works.
Speaking of this, putting (checktag(20)==on) in the while and then having
if(checktag(20) == off) then (
set variable(t,false))
is redundant.

But I don't quite understand- can you tell us exactly which textbox gives you the item, and what tag 20 does?
_________________
"It is so great it is insanely great."

Ysoft_Entertainment · Posted: Tue Apr 27, 2004 4:30 am Post subject:

ok,

if (paymoney(gold)) then (
getmoney(gold)
)
you are right it shouldn't work
it should have been
if (paymoney(gold)) then (
give you item

tag 20==on is actually a choice, of yes, and tag 20 ==off is no

textbox 73 gives you money,
and 71 displays this message (another: yes/no)
again tag 20
_________________
Try my OHR exporter/importer.
OHRGFX
Striving to become better pixel artist then Fenrir Lunaris. Unfortunately the laziness gets in the way of my goals.

TMC · Posted: Tue Apr 27, 2004 12:38 pm Post subject:

ah...

But I meant that
while ((t) and (checktag(20)==on) ) do(
should be
while ((t), and, (checktag(20)==on) ) do(
_________________
"It is so great it is insanely great."

Bob the Hamster · Posted: Tue Apr 27, 2004 9:18 pm Post subject:

TMC · Posted: Wed Apr 28, 2004 12:33 am Post subject:

Oh, of course! I was so used to putting commas around my and's that I forgot that there are 3 ways of seperating commands..

Looking through it, I am still unconvinced that it works,

Umm, sorry what do you mean that textbox 73 gives you money? Do you prehaps mean that it give you the item? Is so, take out the get item.

Alright, armed with a better understanding of the script, I rewrote it:

Ysoft_Entertainment · Posted: Thu Apr 29, 2004 4:35 am Post subject:

thanks, I will test that,
I rewrote my script another way, and I found out that the while loop doesn't work the way I had expected it to work
appearantly(ok, I am not sure how to spell the word), the while loop doesn't go back up, but instead works like qbasics Do, until, it does the validation check at the end of the statement, and doesn't go up to check it in the begining. I think that is so, and by using my script, it proves my theory.
_________________
Try my OHR exporter/importer.
OHRGFX
Striving to become better pixel artist then Fenrir Lunaris. Unfortunately the laziness gets in the way of my goals.

Ysoft_Entertainment · Posted: Thu Apr 29, 2004 8:01 am Post subject:

ok, the script works, thanks
_________________
Try my OHR exporter/importer.
OHRGFX
Striving to become better pixel artist then Fenrir Lunaris. Unfortunately the laziness gets in the way of my goals.

TMC · Posted: Thu Apr 29, 2004 9:14 pm Post subject:

No, that's wrong. The statement is checked before the first iteration of the while loop, if it works out to false, the do block is never run.

However, "for (i, 0, 0) do (...)" will run once... tricky..
_________________
"It is so great it is insanely great."